Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: zsh completion syntax error #3034

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: zsh completion syntax error #3034

merged 1 commit into from
Jul 19, 2024

Conversation

pgarrison
Copy link
Contributor

@pgarrison pgarrison commented Jul 18, 2024 •
edited
Loading

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

zsh completions were broken. Fixed the syntax error

Testing

Tested against my oh-my-zsh setup.

  1. Install system pdm 2.17.0
  2. pdm completion zsh > $ZSH_CUSTOM/plugins/pdm/_pdm
  3. Type pdm sync -- then tab. Error is reproduced
$ pdm sync --zsh: command not found: *:: :->_subcmds
zsh: command not found: *:: :->_subcmds
zsh: command not found: *:: :->_subcmds
zsh: command not found: *:: :->_subcmds
zsh: command not found: *:: :->_subcmds
zsh: command not found: *:: :->_subcmds
  1. From within pdm fork: pdm sync && pdm run pdm completion zsh > $ZSH_CUSTOM/plugins/pdm/_pdm
  2. Type pdm sync -- then tab. See expected completions.

Closes #3031

@frostming frostming merged commit 739d468 into pdm-project:main Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pdm zsh completions failure: pdm zsh: *:: :->_subcmds: command not found...
2 participants
@pgarrison @frostming